fix(picklist-background): add retry counter to picklist update #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage 46.29% 46.29%
=======================================
Files 73 73
Lines 2817 2817
Branches 322 322
=======================================
Hits 1304 1304
Misses 1488 1488
Partials 25 25 ☔ View full report in Codecov by Sentry. |
packages/sfp-cli/src/core/package/deploymentCustomizers/PicklistEnabler.ts
Outdated
Show resolved
Hide resolved
This was referenced Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @azlam-abdulsalam
The picklist background job is a known Salesforce error that can also occur in the install and build jobs. So I can't guarantee whether 3 minutes (6 retries a 30 seconds) is enough. In my tests, 10 seconds wasn't enough. But more runs doesn't make sense at first. We should start with this settings.
I also throw an error when the update was not successfully. In the past we only had an warning log...
Checklist
All items have to be completed before a PR is merged